-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lab] Tested with new Amplify workflow #156
Changes from all commits
f3248e7
b0ada84
4a425aa
1d3a90a
f827337
6a67766
c457624
6f8b7a8
85f1b51
f05622b
7fd60f2
772251a
8d5643d
a814a3f
253044a
9037f1a
218b184
b47abed
f1b856f
0cff134
41c57bb
8b20ccb
a549ac1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
routes/*.js |
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -2,14 +2,72 @@ | |||||||||
* Copyright (c) 2014-2023 Bjoern Kimminich & the OWASP Juice Shop contributors. | ||||||||||
* SPDX-License-Identifier: MIT | ||||||||||
*/ | ||||||||||
import models = require('../models/index') | ||||||||||
import { Request, Response, NextFunction } from 'express' | ||||||||||
import { UserModel } from '../models/user' | ||||||||||
|
||||||||||
import * as utils from '../lib/utils' | ||||||||||
const challengeUtils = require('../lib/challengeUtils') | ||||||||||
const challenges = require('../data/datacache').challenges | ||||||||||
|
||||||||||
class ErrorWithParent extends Error { | ||||||||||
parent: Error | undefined | ||||||||||
} | ||||||||||
|
||||||||||
// vuln-code-snippet start unionSqlInjectionChallenge dbSchemaChallenge | ||||||||||
module.exports = function searchProducts() { | ||||||||||
return (req: Request, res: Response, next: NextFunction) => { | ||||||||||
let criteria: any = req.query.q === 'undefined' ? '' : req.query.q ?? '' | ||||||||||
criteria = (criteria.length <= 200) ? criteria : criteria.substring(0, 200) | ||||||||||
console.log(criteria) | ||||||||||
models.sequelize.query(`SELECT * FROM Products WHERE ((name LIKE '%${criteria}%' OR description LIKE '%${criteria}%') AND deletedAt IS NULL) ORDER BY name`) | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Warning Amplify has been notified that this line contains a vulnerability 🕷️. Vulnerability: CWE-89 Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection') Impact: MEDIUM Code Fix: ✅ Amplify Security has prepared an automated remediation for review. Click here to review and commit the code fix.
Suggested change
The code change addresses the SQL Injection vulnerability by using parameterized queries instead of directly interpolating user input into the SQL command. Here's how this change mitigates the risk: Explanation of the VulnerabilitySQL Injection occurs when an attacker is able to manipulate a SQL query by injecting malicious SQL code through user input. In the original code, the How the Code Change Fixes the Vulnerability
ConclusionBy switching to parameterized queries, the code change effectively prevents SQL injection attacks by ensuring that user input cannot alter the structure of the SQL command. This approach is widely recommended in secure coding practices and is documented in various resources, including: These resources provide further insights into secure coding practices and the importance of using parameterized queries to protect against SQL injection vulnerabilities. Note Have a question or concern about this vulnerability fix? Get an answer within seconds by asking our Concierge 🤖 with |
||||||||||
.then(([products]: any) => { | ||||||||||
const dataString = JSON.stringify(products) | ||||||||||
if (challengeUtils.notSolved(challenges.unionSqlInjectionChallenge)) { // vuln-code-snippet hide-start | ||||||||||
let solved = true | ||||||||||
UserModel.findAll().then(data => { | ||||||||||
const users = utils.queryResultToJson(data) | ||||||||||
if (users.data?.length) { | ||||||||||
for (let i = 0; i < users.data.length; i++) { | ||||||||||
solved = solved && utils.containsOrEscaped(dataString, users.data[i].email) && utils.contains(dataString, users.data[i].password) | ||||||||||
if (!solved) { | ||||||||||
break | ||||||||||
} | ||||||||||
} | ||||||||||
if (solved) { | ||||||||||
challengeUtils.solve(challenges.unionSqlInjectionChallenge) | ||||||||||
} | ||||||||||
} | ||||||||||
}).catch((error: Error) => { | ||||||||||
next(error) | ||||||||||
}) | ||||||||||
} | ||||||||||
if (challengeUtils.notSolved(challenges.dbSchemaChallenge)) { | ||||||||||
let solved = true | ||||||||||
models.sequelize.query('SELECT sql FROM sqlite_master').then(([data]: any) => { | ||||||||||
const tableDefinitions = utils.queryResultToJson(data) | ||||||||||
if (tableDefinitions.data?.length) { | ||||||||||
for (let i = 0; i < tableDefinitions.data.length; i++) { | ||||||||||
if (tableDefinitions.data[i].sql) { | ||||||||||
solved = solved && utils.containsOrEscaped(dataString, tableDefinitions.data[i].sql) | ||||||||||
if (!solved) { | ||||||||||
break | ||||||||||
} | ||||||||||
} | ||||||||||
} | ||||||||||
if (solved) { | ||||||||||
challengeUtils.solve(challenges.dbSchemaChallenge) | ||||||||||
} | ||||||||||
} | ||||||||||
}) | ||||||||||
} // vuln-code-snippet hide-end | ||||||||||
for (let i = 0; i < products.length; i++) { | ||||||||||
products[i].name = req.__(products[i].name) | ||||||||||
products[i].description = req.__(products[i].description) | ||||||||||
} | ||||||||||
res.json(utils.queryResultToJson(products)) | ||||||||||
}).catch((error: ErrorWithParent) => { | ||||||||||
next(error.parent) | ||||||||||
}) | ||||||||||
} | ||||||||||
} | ||||||||||
// vuln-code-snippet end unionSqlInjectionChallenge dbSchemaChallenge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning
Amplify has been notified that this line contains a vulnerability 🕷️.
Vulnerability: CWE-89 Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')
Impact: HIGH
Code Fix: ✅
Amplify Security has prepared an automated remediation for review. Click here to review and commit the code fix.
The code change addresses the SQL Injection vulnerability by implementing parameterized queries instead of directly interpolating user input into the SQL command. Here's how this change mitigates the risk:
Explanation of the Vulnerability
SQL Injection occurs when an attacker is able to manipulate a SQL query by injecting malicious input. In the original code, the user input (
criteria
) is directly concatenated into the SQL string. This means that if an attacker provides specially crafted input, they could alter the intended SQL command, potentially allowing them to execute arbitrary SQL code.How the Code Change Fixes the Vulnerability
Parameterized Queries: The revised code uses a parameterized query with named parameters (
:criteria
). This means that the SQL command structure is defined separately from the data being inserted into it. The database engine treats the parameter as a value rather than executable code.Replacements Object: The
replacements
object is used to safely pass the user input (criteria
) into the SQL query. This ensures that the input is properly escaped and sanitized, preventing any special characters from being interpreted as part of the SQL command.Input Length Limitation: The code still includes a check to limit the length of the
criteria
input to 200 characters. While this is a good practice for performance and security, the main protection against SQL Injection comes from the use of parameterized queries.Benefits of the Change
Further Reading
For more information on preventing SQL Injection and the benefits of parameterized queries, you can refer to the following resources:
By implementing these changes, the code is now more secure against SQL Injection attacks, ensuring that user input is handled safely.
Note
Have a question or concern about this vulnerability fix? Get an answer within seconds by asking our Concierge 🤖 with
@amplify-security
.i.e. @amplify-security are there known performance issues resulting from this fix?