Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENG-740 Use Amplify Security Github Action #154

Merged
merged 1 commit into from
Aug 2, 2024
Merged

ENG-740 Use Amplify Security Github Action #154

merged 1 commit into from
Aug 2, 2024

Conversation

lae
Copy link

@lae lae commented Aug 1, 2024

Copy link

amplify-lab bot commented Aug 1, 2024

✨ Amplify has finished checking this pull request

👍 Everything looks good! No issues detected in 📄 1 file and ❇️ 31 lines of code.

Security Pipeline

Tool Configured Result
Semgrep

Note

To ignore a finding, append @amplify-ignore in a comment to the end of the vulnerable line like // @amplify-ignore or # @amplify-ignore. For more details, visit Amplify Security.

Copy link

@mwillfox mwillfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 I have already updated the TLS for prod to be correct so we can go ahead and merge this.

@lae
Copy link
Author

lae commented Aug 2, 2024

Oh wait, is juice-shop not added to prod anyway? I can just keep this workflow only on lab if we want to keep it that way (and have our other real projects on prod).

0: Failed to mint a run token from Amplify. Please ensure that this repository is configured in Amplify.

@mwillfox
Copy link

mwillfox commented Aug 2, 2024

Oh wait, is juice-shop not added to prod anyway? I can just keep this workflow only on lab if we want to keep it that way (and have our other real projects on prod).

0: Failed to mint a run token from Amplify. Please ensure that this repository is configured in Amplify.

Yes juice-shop is not in prod because we use prod as a production environment for our application code. I completely forgot. Let's go ahead and remove the call to prod and just run it on lab.

@lae lae force-pushed the feature/action branch from 5903641 to e6ffb39 Compare August 2, 2024 16:21
Copy link

amplify-lab bot commented Aug 2, 2024

✨ Amplify has finished checking this pull request

👍 Everything looks good! No issues detected in 📄 1 file and ❇️ 21 lines of code.

Security Pipeline

Tool Configured Result
Semgrep

Note

To ignore a finding, append @amplify-ignore in a comment to the end of the vulnerable line like // @amplify-ignore or # @amplify-ignore. For more details, visit Amplify Security.

@lae lae merged commit e105d16 into master Aug 2, 2024
1 check passed
@lae lae deleted the feature/action branch August 2, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants