forked from juice-shop/juice-shop
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulnerable branch #114
Closed
Closed
Vulnerable branch #114
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
f3248e7
Added search query + introduced vulnerability
mwillfox b0ada84
Amplify Security - Code fix for CWE-89 accepted
amplify-local[bot] 4a425aa
Revert "Amplify Security - Code fix for CWE-89 accepted"
mwillfox 1d3a90a
Amplify Security - Code fix for CWE-89 accepted
amplify-local[bot] f827337
Revert "Amplify Security - Code fix for CWE-89 accepted"
mwillfox 6a67766
Amplify Security - Code fix for CWE-89 accepted
amplify-local[bot] c457624
Revert "Amplify Security - Code fix for CWE-89 accepted"
mwillfox 6f8b7a8
Amplify Security - Code fix for CWE-89 accepted
amplify-local[bot] 85f1b51
Revert "Amplify Security - Code fix for CWE-89 accepted"
mwillfox f05622b
Amplify Security - Code fix for CWE-89 accepted
amplify-local[bot] 7fd60f2
Revert "Amplify Security - Code fix for CWE-89 accepted"
mwillfox 772251a
Amplify Security - Code fix for CWE-89 accepted
amplify-local[bot] 8d5643d
Revert "Amplify Security - Code fix for CWE-89 accepted"
mwillfox a814a3f
Ignored CWE-89 vuln
mwillfox 253044a
Removed CWE-89 ignore comment
mwillfox 9037f1a
Ignored SQL injection
mwillfox 218b184
Removed ignore on vulnerable SQL injection
mwillfox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning
Amplify has been notified that this line contains a vulnerability 🕷️.
Vulnerability: CWE-89 Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')
Impact: HIGH
Code Fix: ✅
Amplify Security has prepared an automated remediation for review. Click here to review and commit the code fix.
The code change fixes the SQL Injection vulnerability by using parameterized queries instead of directly concatenating user input into the SQL query string.
In the original code, the user input
criteria
is directly concatenated into the SQL query string using string interpolation (%${criteria}%
). This allows an attacker to manipulate thecriteria
value and inject malicious SQL code, potentially leading to unauthorized access or data manipulation.In the fixed code, the
criteria
value is passed as a parameter using thereplacements
option in thesequelize.query
method. The:criteria
placeholder is used in the SQL query string, and the actual value is provided in thereplacements
object ({ replacements: { criteria:
%${criteria}%} }
). This ensures that the user input is properly escaped and treated as a parameter, preventing SQL injection attacks.For more information on preventing SQL injection vulnerabilities, you can refer to the following documentation:
Note
Have a question or concern about this vulnerability fix? Get an answer within seconds by asking our Concierge 🤖 with
@amplify-security
.i.e. @amplify-security are there known performance issues resulting from this fix?