[ Local ] Testing @amplify-ignore pt.2

[mwillfox]

Description

A clear and concise summary of the change and which issue (if any) it fixes. Should also include relevant motivation and context.

Resolved or fixed issue:

Affirmation

• My code follows the CONTRIBUTING.md guidelines

[amplify-lab]

✨ Amplify has finished checking this pull request

⚠️ 1 issue detected in 📄 1 file and ❇️ 60 lines of code.

Security Pipeline

Tool	Configured	Result
Semgrep	✅	⚠️

Vulnerabilities Detected

Vulnerability	Path	Fingerprint
CWE-89	routes/search.ts:22	[eec4f3b0...]

Note

For more details, visit Amplify Security.

[amplify-lab]

Warning

Amplify has been notified that this line contains a vulnerability 🕷️.

Vulnerability: CWE-89 Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')

Impact: HIGH

Guidance: ✅

Code Fix: ✅

Learn more about this alert

Suggested change

	models.sequelize.query(`SELECT * FROM Products WHERE ((name LIKE '%${criteria}%' OR description LIKE '%${criteria}%') AND deletedAt IS NULL) ORDER BY name`) // @amplify-ignore
	.then(([products]: any) => {
	models.sequelize.query('SELECT * FROM Products WHERE ((name LIKE :criteria OR description LIKE :criteria) AND deletedAt IS NULL) ORDER BY name', { replacements: { criteria: `%${criteria}%` }, type: models.sequelize.QueryTypes.SELECT }) // @amplify-ignore
	.then((products: any) => {

The code change fixes the SQL Injection vulnerability by using parameterized queries instead of directly concatenating user input into the SQL query string.

In the original code, the user input criteria is directly concatenated into the SQL query string using string interpolation (%${criteria}%). This allows an attacker to manipulate the criteria value and inject malicious SQL code, potentially leading to unauthorized access or data manipulation.

In the updated code, the models.sequelize.query method is used with parameterized queries. The :criteria placeholder is used in the query string, and the actual value of criteria is passed as a replacement using the replacements option. This ensures that the user input is properly sanitized and treated as a parameter, preventing SQL injection attacks.

By using parameterized queries, the code ensures that user input is properly escaped and treated as data, rather than executable code. This mitigates the SQL Injection vulnerability and improves the security of the application.

For more information on SQL Injection and how to prevent it, you can refer to the OWASP SQL Injection Prevention Cheat Sheet: OWASP SQL Injection Prevention Cheat Sheet

Note

Have a question or concern about this vulnerability fix? Get an answer within seconds by asking our Concierge 🤖 with @amplify-security.
i.e. @amplify-security are there known performance issues resulting from this fix?

[amplify-local]

✨ Amplify has finished checking this pull request

👍 Everything looks good! No issues detected in 📄 1 file and ❇️ 60 lines of code.

Security Pipeline

Tool	Configured	Result
Semgrep	✅	✅

Note

To ignore a finding, append @amplify-ignore in a comment to the end of the vulnerable line like // @amplify-ignore or # @amplify-ignore. For more details, visit Amplify Security.