Vulnerable branch

[mwillfox]

Description

A clear and concise summary of the change and which issue (if any) it fixes. Should also include relevant motivation and context.

Resolved or fixed issue:

Affirmation

• My code follows the CONTRIBUTING.md guidelines

[amplify-lab]

✨ Amplify has finished checking this pull request

⚠️ 1 issue detected in 📄 1 file and ❇️ 60 lines of code.

Security Pipeline

Tool	Configured	Result
Semgrep	✅	⚠️

Vulnerabilities Detected

Vulnerability	Path	Fingerprint
CWE-89	routes/search.ts:22	[eec4f3b0...]

Note

For more details, visit Amplify Security.

[amplify-lab]

Warning

Amplify has been notified that this line contains a vulnerability 🕷️.

Vulnerability: CWE-89 Improper Neutralization of Special Elements used in an SQL Command ('SQL Injection')

Impact: HIGH

Guidance: ✅

Code Fix: ✅

Learn more about this alert

Suggested change

	models.sequelize.query(`SELECT * FROM Products WHERE ((name LIKE '%${criteria}%' OR description LIKE '%${criteria}%') AND deletedAt IS NULL) ORDER BY name`) // vuln-code-snippet vuln-line unionSqlInjectionChallenge dbSchemaChallenge
	.then(([products]: any) => {
	models.sequelize.query('SELECT * FROM Products WHERE ((name LIKE ? OR description LIKE ?) AND deletedAt IS NULL) ORDER BY name', { replacements: [`%${criteria}%`, `%${criteria}%`], type: models.sequelize.QueryTypes.SELECT }) // vuln-code-snippet vuln-line unionSqlInjectionChallenge dbSchemaChallenge
	.then((products: any) => {

The code change fixes the SQL Injection vulnerability by using parameterized queries instead of directly concatenating user input into the SQL query string.

In the original code, the user input criteria is directly interpolated into the SQL query string using string concatenation. This allows an attacker to manipulate the criteria value and inject malicious SQL code, potentially leading to unauthorized access or data manipulation.

In the fixed code, the criteria value is passed as a parameter to the sequelize.query() method using the replacements option. This ensures that the user input is properly sanitized and treated as a parameter rather than part of the SQL query string. Parameterized queries prevent SQL Injection by separating the SQL code from the user input, making it impossible for an attacker to inject malicious code.

For more information on SQL Injection vulnerabilities and how to prevent them, you can refer to the OWASP SQL Injection Prevention Cheat Sheet: OWASP SQL Injection Prevention Cheat Sheet

Note

Have a question or concern about this vulnerability fix? Get an answer within seconds by asking our Concierge 🤖 with @amplify-security.
i.e. @amplify-security are there known performance issues resulting from this fix?