Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same-level elements with common prefix #50

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mattbornski
Copy link
Contributor

Summary

Allow elements at the same level with a common prefix to be unflattened

Bug Fixes/New Features

  • Fix a bug where a piece of logic designed to suppress conflicts when basic values and flattened structures claimed the same key space; the logic inadvertently suppressed scenarios where multiple basic values existed with keys where one key was a prefix of the other.

How to Verify

A new test has been added for this scenario

Side Effects

Possible if you are depending on these keys being silently dropped?

Resolves

  • A bug discovered and reported here

Tests

All tests, including the new one, pass

Code Reviewer(s)

@

…unflattening (was squashed to avoid a, a_2 causing conflict in the resulting JSON object structure).
@pep8speaks
Copy link

pep8speaks commented Jul 3, 2019

Hello @mattbornski! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-10-08 21:50:10 UTC

@amirziai
Copy link
Owner

amirziai commented Oct 5, 2019

thanks for the pr @mattbornski, do you mind checking why the travis build is failing?

@mattbornski
Copy link
Contributor Author

mattbornski commented Oct 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants