Ensure that NVME symlinks are not lost on udev change events #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2022 09:33
Fixes amazonlinux#22 Symlinks need to be created on both add and change udev events, otherwise they're lost any time a change event is opened, e.g. when a device is open in read/write mode, e.g. when creating or mounting a filesystem.
nmeyerhans
force-pushed
the
bugfix-nvme-symlink
branch
from
9ebe234 to
ba7f126
Compare
halfdime-code
approved these changes
Feb 11, 2022
|
Thank you for the quick response to this issue. One quick note, I think you are missing a not in the ticket title?
|
nmeyerhans
changed the title
😄 Thanks for noticing that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
Description of changes:
#9 was overly aggressive in the events that it filtered, leading to a regression where any udev change event would remove the symlinks for the corresponding devices. This change ensures that the rules trigger for both "add" and "change" events, and that only "remove" events are skipped.
The RPM spec is update twice by this PR: once for the earlier 1.4-1 release, and once for a new 1.4.1-1 release that I'll generate once it is merged.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.