Fix infinite loop when reading truncated data #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
This PR addresses an issue where an infinite loop could be triggered due to corrupted or truncated ion data.
Previous to this PR when retrieving bytes from the underlying input, RawBinaryReader did not check the return value of the call to Read. In the event that there was not enough bytes to return, Read would return 0 and the RawBinaryReader would get stuck in an infinite loop trying to read more data.
This PR adds the check of the return value and throws an
UnexpectedEofExceptionif the amount read is zero. A unit test to ensure this behavior was also added.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.