Skip to content

Use build args for versions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Conversation

dnephin
Copy link
Collaborator

@dnephin dnephin commented Nov 20, 2015

Now that build args exist, it's a lot easier to do updates for this image.

I've made VERSION an arg, and the "check for existing" just look for the image instead of a git tag. That way we don't need git tags or to push to a git repo to do updates.

I think this will make it much easier to run as a jenkins job.

Signed-off-by: Daniel Nephin <[email protected]>
@aluzzardi
Copy link
Owner

Why RCs?

@dnephin
Copy link
Collaborator Author

dnephin commented Dec 22, 2015

We need to test against RCs, otherwise we end up with big surprises on release day.

Master is too volatile, and would result in a lot of failures that we can't do anything about.

@aluzzardi
Copy link
Owner

We do test against master in Swarm - we don't want to wait until RCs before finding out that the API is broken, which happens about once a month /cc @vieux

@dnephin
Copy link
Collaborator Author

dnephin commented Dec 22, 2015

Makes sense, we have slightly different requirements here. From Compose we only care about backwards compatibility and a few new features we plan on using, so we can wait for RC to find any breaking changes.

For Swarm you need to actually have API compatibility, so finding out about changes asap is important.

Are you still using this image for Swarm? I thought you were using dind-master exclusively ?

I have been uploading RC images to hub for a couple releases now.

dnephin and others added 13 commits January 15, 2016 18:10
The single binary is now a tarball.

Signed-off-by: Daniel Nephin <[email protected]>
Signed-off-by: Joffrey F <[email protected]>
Build all missing tags
Adapt script to use new distribution channels
Account for new archive name
Signed-off-by: Joffrey F <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants