Revert "Improve link handling in content endpoint" #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanHallam
approved these changes
Aug 20, 2024
tahb
deleted the
revert-2823-content-modelling/377-improve-link-handling-in-content-endpoint
branch
|
Since being reverted @richardTowers may have found the flaw that might have improved the performance. Should this work need to go back in for any reason (perhaps someone else wants to query by the That said I think the new approach we're taking of a dedicated endpoint for embedded content is a good idea so we'll leave this reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2823
During the testing of this change on integration we found we got timeouts when trying to send the
field:link_set_links.We have proposed an alternative way for us to find embedded content via a new endpoint altogether. More information such as benchmarking can be found there.
As this doesn't work on integration it is unlikely that any API consumers other than us have started using this.
I asked in govuk-publishing-platform if there was a formal process for deprecating this and @callumknights suggested a straight revert should be fine.