Add facet values to OVA finder #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanb-gds
reviewed
Aug 2, 2024
There was a problem hiding this comment.
I'm assuming the + will just be URL encoded before being sent as a parameter to Search API, but might be better not to risk it? I can imagine a scenario where Search API doesn't decode it properly and then ends up searching for %2B literally or some such nonsense
content_schemas/dist/formats/specialist_document/frontend/schema.json
Outdated
Show resolved
Hide resolved
lauraghiorghisor-tw
force-pushed
the
changes-to-ova-finder
branch
from
9ed76ee to
79d4e57
Compare
ryanb-gds
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trello