Add link_collection example for popular links on GOV.UK #2816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syed-ali-tw
force-pushed
the
link-collections-example
branch
6 times, most recently
from
07ea0a7 to
2574850
Compare
syed-ali-tw
force-pushed
the
link-collections-example
branch
3 times, most recently
from
dcccdfa to
0260a72
Compare
syed-ali-tw
force-pushed
the
link-collections-example
branch
from
0260a72 to
e824b23
Compare
brucebolt
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 2 changes
Make popular schemas to not require base path when as a link
Explanation:
Popular links are set of six links on homepage under title 'Popular on GOV.UK' and they do not need a separate base path to homepage. Popular links utilises link_collection schema and link_collection schema has base_path set as 'optional' (incase we want to use this as for a different content which may require a base_path).
Now, setting base_path as optional does not necessarily sets it as optional for frontend schema, we still need to add a rule here to make sure it does not requires a base path
Add an example for homepage frontend content with popular links as link to homepage
Trello
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.