Republish drafts of other translations on PUT of new translation #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gweaton
approved these changes
Jun 13, 2024
| @@ -200,6 +202,29 @@ def clear_draft_item_of_different_locale_but_matching_base_path | |||
| ) | |||
| end | |||
|
|
|||
| def update_draft_items_of_different_locale_but_matching_content_id | |||
| return unless payload[:base_path] | |||
| return if Document.where(content_id: payload[:content_id], locale: payload[:locale]).any? | |||
There was a problem hiding this comment.
Is it worth adding a couple of tests for these early returns? Might also help serve as documentation.
There was a problem hiding this comment.
Yes, that's a good idea, I'll add them.
Gweaton
reviewed
Jun 13, 2024
| .map(&:draft) | ||
| .compact | ||
|
|
||
| after_transaction_commit do |
There was a problem hiding this comment.
What's the transaction here? Is it that the rest of the call method executes successfully and we only want to run this if it does? Or is it scoped to this method?
There was a problem hiding this comment.
Yes, it's after the call (I think it's this line that executes the block), so we only send the payload to content store once the data has actually been committed to the database.
When a draft translation is added and another translation of the same content ID exists, we need to send the existing translation(s) downstream so their `available_translations` links can be updated to include the new translation. We're not currently doing this, which leads to a situation where the link to the new translation never appears on the draft of the existing translations.
brucebolt
force-pushed
the
republish-translation-put
branch
from
c801987 to
d3c4199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a draft translation is added and another translation of the same content ID exists, we need to send the existing translation(s) downstream so their
available_translationslinks can be updated to include the new translation.We're not currently doing this, which leads to a situation where the link to the new translation never appears on the draft of the existing translations.
Trello card