Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Remove specialist topics from database #2684

Conversation

unoduetre
Copy link
Contributor

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

Follow these steps if you are doing a Rails upgrade.

@hannako
Copy link
Contributor

hannako commented Apr 9, 2024

Sorry @unoduetre am only getting to this now...

I don't think we need/should do this:

  • When a document is unpublished/redirected it remains in the database. We should follow that pattern.
  • Publishing API is the source of truth, it stores all of the documents, along with their current state (via the Edition) so deleting these documents means we are losing access that that history.

@brucebolt do you agree?

@JonathanHallam
Copy link
Contributor

@hannako I agree, not sure we need to do this. I assume all the specialist topics are already marked as withdrawn or unpublished so I don't think there's a need to do this

@unoduetre
Copy link
Contributor Author

Closing the PR.

@unoduetre unoduetre closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants