Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove topics, additional_topics and primary topic from email_alert schema #2682

Merged

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented Mar 18, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

Follow these steps if you are doing a Rails upgrade.

Part of https://trello.com/c/2LcbNRSQ/2417-%F0%9F%8F%94epic-remove-specialist-topic-code-from-publishing-api-l

What

The tags field of the email alert schema contains the following keys: topics, additional topics and primary topic. This PR is about:

Why

Trello card

How

see steps above

@unoduetre unoduetre marked this pull request as ready for review March 18, 2024 14:36
@unoduetre unoduetre changed the title Remove remove topics, additional_topics and primary topic from email_alert schema Remove topics, additional_topics and primary topic from email_alert schema Mar 19, 2024
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mat - looks good to me 🏅

Copy link
Member

@brucebolt brucebolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would you be able to add an extra comment to the second commit message explaining what was done (e.g. auto-regenerating the schema files).

The content schemas in this commit from the dist directory have been regenerated
by using 'bundle exec rake build_schemas'
@unoduetre unoduetre force-pushed the 2417-remove-specialist-topic-code-from-publishing-api-l-5 branch from c693f64 to 1b87afa Compare April 2, 2024 08:21
@unoduetre
Copy link
Contributor Author

Looks good to me. Would you be able to add an extra comment to the second commit message explaining what was done (e.g. auto-regenerating the schema files).

I've added a longer explanation to that commit.

@unoduetre unoduetre merged commit ecca591 into main Apr 2, 2024
43 checks passed
@unoduetre unoduetre deleted the 2417-remove-specialist-topic-code-from-publishing-api-l-5 branch April 2, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants