Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove topic_taxonomy_taxons from expanded links #2677

Merged

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented Mar 18, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.

Follow these steps if you are doing a Rails upgrade.

Part of https://trello.com/c/2LcbNRSQ/2417-%F0%9F%8F%94epic-remove-specialist-topic-code-from-publishing-api-l

What

topic_taxonomy_taxons appear to be a legacy field that stored a mapping between specialist topics and taxonomy topics. So we should retire them.

Why

Remove tech debt
Trello ticket

How

See https://github.com/alphagov/publishing-api/blob/main/docs/content_schemas/changing-an-existing-content-schema.md

It has been verified by @hannako that there are no topic_taxonomy_taxon links in the database—please, see the comment below.

Link.where(link_type: "topic_taxonomy_taxons").count 
=> 0

The following search among all of our GitHub repositories shows that this field is no longer used:
org:alphagov topic_taxonomy_taxons
The returned search result from the whitehall repository is unrelated as it's just a name of a cache key:

    TAXONS_CACHE_KEY = "topic_taxonomy_taxons".freeze

@unoduetre unoduetre marked this pull request as ready for review March 18, 2024 12:20
Copy link
Contributor

@hannako hannako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks Mat.

I checked in the publishing API database:

Link.where(link_type: "topic_taxonomy_taxons").count 
=> 0

And this also suggests there's nothing in the frontend rendering or email alerts that's relying on this field.

Please could you add the above into the PR description.

Copy link
Contributor

@jkempster34 jkempster34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for splitting up the commits!

@unoduetre unoduetre merged commit 011bcb3 into main Mar 25, 2024
42 checks passed
@unoduetre unoduetre deleted the 2417-remove-specialist-topic-code-from-publishing-api-l-1 branch March 25, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants