Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop-factory_bot from 2.23.1 to 2.24.0 #480

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 21, 2023

Bumps rubocop-factory_bot from 2.23.1 to 2.24.0.

Release notes

Sourced from rubocop-factory_bot's releases.

RuboCop factory_bot v2.24.0

What's Changed

  • Fix FactoryBot/AssociationStyle cop to ignore explicit associations with strategy: :build. (@​pirj)
  • Change FactoryBot/CreateList so that it is not an offense if not repeated multiple times. (@​ydah)
  • Fix a false positive for FactoryBot/AssociationStyle when association is called in trait block and column name is keyword. (@​ydah)
  • Fix a false positive for FactoryBot/AssociationStyle when EnforcedStyle: Explicit and using trait within trait. (@​ydah)
  • Change FactoryBot/AssociationStyle, FactoryBot/AttributeDefinedStatically, FactoryBot/CreateList and FactoryBot/FactoryClassName to work with minitest style directory. (@​ydah)
  • Add FactoryBot/IdSequence cop. (@​owst)

Full Changelog: rubocop/rubocop-factory_bot@v2.23.1...v2.24.0

Changelog

Sourced from rubocop-factory_bot's changelog.

2.24.0 (2023-09-18)

  • Fix FactoryBot/AssociationStyle cop to ignore explicit associations with strategy: :build. ([@​pirj])
  • Change FactoryBot/CreateList so that it is not an offense if not repeated multiple times. ([@​ydah])
  • Fix a false positive for FactoryBot/AssociationStyle when association is called in trait block and column name is keyword. ([@​ydah])
  • Fix a false positive for FactoryBot/AssociationStyle when EnforcedStyle: Explicit and using trait within trait. ([@​ydah])
  • Change FactoryBot/AssociationStyle, FactoryBot/AttributeDefinedStatically, FactoryBot/CreateList and FactoryBot/FactoryClassName to work with minitest style directory. ([@​ydah])
  • Add FactoryBot/IdSequence cop. ([@​owst])
Commits
  • 8deeb64 Merge pull request #67 from rubocop/bump-version
  • bfffe8d Bump version to v2.24.0
  • 8e74bc1 Merge pull request #52 from owst/add_id_sequence_cop
  • 832bb0f Add new FactoryBot/IdSequence cop
  • 9f74ec3 Merge pull request #69 from rubocop/dependabot/github_actions/actions/checkout-4
  • 8f6ab5f Bump actions/checkout from 3 to 4
  • 13e3d14 Merge pull request #55 from rubocop/ydah/fix/53
  • 4ce5025 Change FactoryBot/AssociationStyle, FactoryBot/AttributeDefinedStatically...
  • ec937ec Merge pull request #68 from rubocop/fix-offense
  • b860873 Fix rubocop offense
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Copy link

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@chrisroos
Copy link
Contributor

@dependabot rebase

Bumps [rubocop-factory_bot](https://github.com/rubocop/rubocop-factory_bot) from 2.23.1 to 2.24.0.
- [Release notes](https://github.com/rubocop/rubocop-factory_bot/releases)
- [Changelog](https://github.com/rubocop/rubocop-factory_bot/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-factory_bot@v2.23.1...v2.24.0)

---
updated-dependencies:
- dependency-name: rubocop-factory_bot
  dependency-type: indirect
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-factory_bot-2.24.0 branch from c429de1 to 3074347 Compare November 22, 2023 12:47
Copy link
Contributor

@chrisroos chrisroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this minor version bump given that all the tests pass.

@chrisroos chrisroos merged commit 9712a63 into main Nov 22, 2023
3 checks passed
@chrisroos chrisroos deleted the dependabot/bundler/rubocop-factory_bot-2.24.0 branch November 22, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant