Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rm into_request #725

Closed
wants to merge 2 commits into from
Closed

refactor: rm into_request #725

wants to merge 2 commits into from

Conversation

tcoratger
Copy link
Contributor

The into_request function that transforms a rpc Transaction to a rpc TransactionRequest was redundant and less Rust idiomatic than the From<Transaction> for TransactionRequest implementation.

As a result, the into_request function is removed and its content is migrated to From<Transaction> for TransactionRequest implementation.

@prestwich
Copy link
Member

rebase after #724

@DaniPopes DaniPopes marked this pull request as draft May 13, 2024 07:13
@Evalir Evalir marked this pull request as ready for review May 17, 2024 05:19
@Evalir Evalir changed the title rm into_request refactor: rm into_request May 17, 2024
DaniPopes
DaniPopes reviewed May 17, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like this type of changes, since it requires importing the other type to convert to it either with .into or ::from.
I also don't think we should break API just for this change.

@prestwich
Copy link
Member

i'm fine closing it if we don't like it

@mattsse
Copy link
Member

mattsse commented May 19, 2024

agree with @DaniPopes

I prefer separate into calls,

@mattsse mattsse closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes left review comments

@prestwich prestwich prestwich approved these changes

@Evalir Evalir Evalir approved these changes

@gakonst gakonst Awaiting requested review from gakonst

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tcoratger @prestwich @mattsse @Evalir @DaniPopes