Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing to in 4844 conversion #366

Merged
merged 2 commits into from
Mar 22, 2024
Merged

fix: missing to in 4844 conversion #366

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6e80b7
fix: missing to in 4844 conversion
prestwich Mar 22, 2024
15ce20a
Merge branch 'main' into prestwich/missing-to
DaniPopes Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions crates/rpc-types/src/eth/transaction/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,35 @@
#[allow(missing_docs)]
/// Error variants when converting from [crate::Transaction] to [alloy_consensus::Signed]
/// transaction.
#[derive(Debug, thiserror::Error)]
pub enum ConversionError {
/// Missing `gasPrice` field for Legacy transaction.
#[error("missing `gasPrice` field for Legacy transaction")]
MissingGasPrice,
/// Missing signature for transaction.
#[error("missing signature for transaction")]
MissingSignature,
/// Missing `accessList` field for EIP-2930 transaction.
#[error("missing `accessList` field for EIP-2930 transaction")]
MissingAccessList,
/// Missing `maxFeePerGas` field for EIP-1559 transaction.
#[error("missing `maxFeePerGas` field for EIP-1559 transaction")]
MissingMaxFeePerGas,
/// Missing `to` field for EIP-4844 transaction.
#[error("missing `to` field for EIP-4844 transaction")]
MissingTo,
/// Missing `maxPriorityFeePerGas` field for EIP-1559 transaction.
#[error("missing `maxPriorityFeePerGas` field for EIP-1559 transaction")]
MissingMaxPriorityFeePerGas,
/// Missing `maxFeePerBlobGas` field for EIP-1559 transaction.
#[error("missing `maxFeePerBlobGas` field for EIP-1559 transaction")]
MissingMaxFeePerBlobGas,
/// Missing `chainId` field for EIP-1559 transaction.
#[error("missing `chainId` field for EIP-155 transaction")]
MissingChainId,
#[error("missing `to` field for EIP-4844 transaction")]
MissingTo,
/// [`alloy_primitives::SignatureError`].
#[error(transparent)]
SignatureError(#[from] alloy_primitives::SignatureError),
/// Error during EIP-2718 transaction coding.
#[error(transparent)]
Eip2718Error(#[from] alloy_eips::eip2718::Eip2718Error),
}
Loading