Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Signer implementations for object-safe smart pointers #334

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Mar 18, 2024

Same as #274 (comment):

TIL this is necessary for dyn Provider to work, because otherwise auto_impl puts U: Provider + Sized bounds on the generic implementations if Self: Sized methods are not marked with keep_default_for. I added a test for this in this file

@DaniPopes DaniPopes merged commit bef05ad into main Mar 18, 2024
16 checks passed
@DaniPopes DaniPopes deleted the dani/dyn-signer branch March 18, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants