-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geolocation #115
base: master
Are you sure you want to change the base?
Geolocation #115
Conversation
Can you explain or do you have some ressource what your settings are doing? As far as I understand you're mixing a few things: Geo-Location, accept language headers and country specific search engine settings (possibly derived from geo location queries?). My general policy to geo location was so far not to include it, as it is opt-in anyway. And the other options deserve own settings. Possibly accept-language and search default could be merged, but geolocation is something else. |
I merged all this features in one because I thought it might make sense do disable all option wich could be used to geolocate a person. Otherwise it might be possible that an person enables some features wich should disable geolocation and some options might still be there to track this person. The other point is, that you could switch the geolocation service from google to mozilla. I'm still investigating if there are some other open source projects wich provide geolocation. |
I think this should not be merged this way for two reasons:
split into different settings it may be useful, i.e. "use english default language (helps hiding your location)" may be a setting. |
Yeah, in the meantime, I've been thinking, and I agree with you. We should drop the pull request and I continue in time. |
The settings are interesting, but not in this combination for the default profile. The profile infrastructure needs to be more flexible. See #71, #57, #25. |
1276e30
to
0c10046
Compare
6b454a5
to
ab6c362
Compare
Revisiting the pull request:
So if this is (still) a problem I'd like to merge it in some way, but I like to understand the details and possibly to add a user-friendly description that explains a bit of why it leaks the position. |
No description provided.