split up tests

allenai · Dec 20, 2024 · ab1b146 · ab1b146
1 parent 3c0fb7f
commit ab1b146
Showing 1 changed file with 43 additions and 41 deletions.
diff --git a/tests/unit/test_filter.py b/tests/unit/test_filter.py
@@ -9,44 +9,46 @@
 TEST_INFRA_LAT = 5.678
 
 
-@pytest.fixture
-def single_point_infra_filter(tmp_path: pathlib.Path) -> NearInfraFilter:
-    geojson_data = {
-        "type": "FeatureCollection",
-        "properties": {},
-        "features": [
-            {
-                "type": "Feature",
-                "properties": {},
-                "geometry": {
-                    "type": "Point",
-                    "coordinates": [TEST_INFRA_LON, TEST_INFRA_LAT],
-                },
-            }
-        ],
-    }
-    fname = tmp_path / "data.geojson"
-    with fname.open("w") as f:
-        json.dump(geojson_data, f)
-
-    return NearInfraFilter(infra_url=str(fname))
-
-
-def test_near_infra_filter(single_point_infra_filter: NearInfraFilter) -> None:
-    # Test case 1: Detection is exactly on infrastructure.
-    # The coordinates are directly extracted from the geojson file.
-    # Since this point is exactly an infrastructure point, the filter should discard it (return True)
-    assert single_point_infra_filter.should_filter(
-        TEST_INFRA_LAT,
-        TEST_INFRA_LON,
-    ), "Detection should be filtered out as it is located on infrastructure."
-
-    # Test case 2: Detection is close to infrastructure.
-    assert single_point_infra_filter.should_filter(
-        TEST_INFRA_LAT + 0.0001, TEST_INFRA_LON + 0.0001
-    ), "Detection should be filtered out as it is too close to infrastructure."
-
-    # Test case 3: Detection is far from infrastructure.
-    assert not single_point_infra_filter.should_filter(
-        TEST_INFRA_LAT + 0.5, TEST_INFRA_LON + 0.5
-    ), "Detection should be kept as it is far from infrastructure."
+class TestNearInfraFilter:
+    @pytest.fixture
+    def single_point_infra_filter(self, tmp_path: pathlib.Path) -> NearInfraFilter:
+        geojson_data = {
+            "type": "FeatureCollection",
+            "properties": {},
+            "features": [
+                {
+                    "type": "Feature",
+                    "properties": {},
+                    "geometry": {
+                        "type": "Point",
+                        "coordinates": [TEST_INFRA_LON, TEST_INFRA_LAT],
+                    },
+                }
+            ],
+        }
+        fname = tmp_path / "data.geojson"
+        with fname.open("w") as f:
+            json.dump(geojson_data, f)
+
+        return NearInfraFilter(infra_url=str(fname))
+
+    def test_exactly_on_infra(self, single_point_infra_filter: NearInfraFilter) -> None:
+        # Test when detection is exactly on infrastructure.
+        # The coordinates are directly extracted from the geojson file.
+        # Since this point is exactly an infrastructure point, the filter should discard it (return True)
+        assert single_point_infra_filter.should_filter(
+            TEST_INFRA_LAT,
+            TEST_INFRA_LON,
+        ), "Detection should be filtered out as it is located on infrastructure."
+
+    def test_close_to_infra(self, single_point_infra_filter: NearInfraFilter) -> None:
+        # Test when detection is close to infrastructure.
+        assert single_point_infra_filter.should_filter(
+            TEST_INFRA_LAT + 0.0001, TEST_INFRA_LON + 0.0001
+        ), "Detection should be filtered out as it is too close to infrastructure."
+
+    def test_far_from_infra(self, single_point_infra_filter: NearInfraFilter) -> None:
+        # Test when detection is far from infrastructure.
+        assert not single_point_infra_filter.should_filter(
+            TEST_INFRA_LAT + 0.5, TEST_INFRA_LON + 0.5
+        ), "Detection should be kept as it is far from infrastructure."