Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[risk=low][RW-13494] Renaming of free tier in many locations #9092

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jmthibault79
Copy link
Collaborator

@jmthibault79 jmthibault79 commented Feb 4, 2025

Similar to #8994, this is a cleanup PR renaming "expired" and "expiry" to "exhausted" in the context of initial credits where the user has spent above their limit. "Expired" should be restricted to when a user has passed the expiration time of their initial credits. Also rename "free tier" and "free credits" to "initial credits" where appropriate.

This PR is not intended to be comprehensive. Many references to Free Tier remain.


PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

@jmthibault79 jmthibault79 changed the title rename expired to exhausted where appropriate [risk=low][no ticket] Renaming of expired, expiry, and free tier in many locations Feb 4, 2025
@jmthibault79 jmthibault79 changed the title [risk=low][no ticket] Renaming of expired, expiry, and free tier in many locations [risk=low][RW-13494] Renaming of expired, expiry, and free tier in many locations Feb 6, 2025
@jmthibault79 jmthibault79 force-pushed the joel/exhaustion branch 2 times, most recently from ce89215 to 4e22c38 Compare February 7, 2025 20:00
@@ -1,14 +1,14 @@
package org.pmiops.workbench.initialcredits;
package org.pmiops.workbench.utils;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these can be useful more generally

initialCreditsExhaustionQueue and ExhaustedInitialCreditsEventRequest;
@jmthibault79 jmthibault79 changed the title [risk=low][RW-13494] Renaming of expired, expiry, and free tier in many locations [risk=low][RW-13494] Renaming of free tier in many locations Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant