fix: clean up reviewer related configs

GUIDE.md

@@ -326,9 +326,7 @@ You can assign reviewers on the PR.
 
 ```js
 module.exports = {
-  pullRequestReviewer: "user-name-or-team-name"
-  // or
-  pullRequestReviewer: ["user1", "user2", "user3"]
+  pullRequestReviewers: ["user1", "user2", "user3"]
 };
 ```
 

packages/shipjs-lib/src/lib/config/defaultConfig.js

@@ -67,8 +67,8 @@ export default {
     ];
     return lines.join('\n');
   },
-  pullRequestReviewer: undefined,
-  pullRequestTeamReviewer: undefined,
+  pullRequestReviewers: undefined,
+  pullRequestTeamReviewers: undefined,
   mergeStrategy: {
     toSameBranch: ['master'],
     // toReleaseBranch: {

packages/shipjs/src/step/prepare/__tests__/createPullRequest.spec.js

@@ -25,7 +25,7 @@ const getDefaultParams = ({
     formatPullRequestTitle,
     formatPullRequestMessage,
     remote: 'origin',
-    pullRequestReviewer: ['foo', 'bar'],
+    pullRequestReviewers: ['foo', 'bar'],
   },
   noBrowse,
   dir: '.',

packages/shipjs/src/step/prepare/createPullRequest.js

@@ -32,8 +32,8 @@ export default async ({
       formatPullRequestTitle,
       formatPullRequestMessage,
       publishCommand,
-      pullRequestReviewer,
-      pullRequestTeamReviewer,
+      pullRequestReviewers,
+      pullRequestTeamReviewers,
       remote,
       monorepo,
     } = config;
@@ -89,12 +89,6 @@ export default async ({
       return {};
     }
 
-    const reviewers = Array.isArray(pullRequestReviewer)
-      ? pullRequestReviewer
-      : (pullRequestReviewer || '').split(',');
-    const teamReviewers = Array.isArray(pullRequestTeamReviewer)
-      ? pullRequestTeamReviewer
-      : (pullRequestTeamReviewer || '').split(',');
     const octokit = new Octokit({
       auth: `token ${process.env.GITHUB_TOKEN}`,
     });
@@ -109,13 +103,16 @@ export default async ({
       base: destinationBranch,
     });
 
-    if (reviewers.length > 0 || teamReviewers.length > 0) {
+    if (
+      pullRequestReviewers.length > 0 ||
+      pullRequestTeamReviewers.length > 0
+    ) {
       await octokit.pulls.createReviewRequest({
         owner,
         repo,
         pull_number: number, // eslint-disable-line camelcase
-        reviewers,
-        team_reviewers: teamReviewers, // eslint-disable-line camelcase
+        reviewers: pullRequestReviewers,
+        team_reviewers: pullRequestTeamReviewers, // eslint-disable-line camelcase
       });
     }
 

website/guide/useful-config.md

@@ -180,16 +180,12 @@ You can assign reviewers on the PR.
 
 ```js
 module.exports = {
-  pullRequestReviewer: "user-login"
-  // or
-  pullRequestReviewer: ["user-login1", "user-login2", "user-login3"],
+  pullRequestReviewers: ["user-login1", "user-login2", "user-login3"],
 
   ...
 
   // also
-  pullRequestTeamReviewer: "team-slug",
-  // or
-  pullRequestTeamReviewer: ["team-slug1", "team-slug2"],
+  pullRequestTeamReviewers: ["team-slug1", "team-slug2"],
 };
 ```
 

website/reference/all-config.md

@@ -121,20 +121,28 @@ beforeCommitChanges: ({ nextVersion, releaseType, exec, dir }) => {
 
 This is a lifecycle hook which is executed right before `git commit` happens. You can put additional code like modifying some other files.
 
-## `pullRequestReviewer`
+## `pullRequestReviewers`
 
 _default:_ `undefined`
 
-You can put either a string or an array of strings.
+You can put an array of strings.
 
 ```js
-pullRequestReviewer: 'user-name-or-team-name';
-// or
-pullRequestReviewer: ['user1', 'user2', 'user3'];
+pullRequestReviewers: ['user1', 'user2', 'user3'];
 ```
 
 One thing you need to be aware of is, you cannot assign yourself as a reviewer. You can put github username of your team or colleagues.
 
+## `pullRequestTeamReviewers`
+
+_default:_ `undefined`
+
+You can put an array of strings.
+
+```js
+pullRequestTeamReviewers: ['team-username1'];
+```
+
 ## `mergeStrategy`
 
 _default:_