This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Cherrypick a few dash fixes #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve time shift color and pattern * Revert change * Fix js unit test * Move code to better place, add unit test * Move classed code to backend * Remove console.log * Remove 1 hour time compare * Remove unused import (cherry picked from commit 57e1256)
(cherry picked from commit 723bbe4)
(cherry picked from commit daf2116)
(cherry picked from commit 9f6ac08)
Codecov Report
@@ Coverage Diff @@
## airbnb-master #86 +/- ##
================================================
- Coverage 63.23% 63.2% -0.03%
================================================
Files 351 351
Lines 22037 22043 +6
Branches 2463 2465 +2
================================================
- Hits 13935 13933 -2
- Misses 8090 8098 +8
Partials 12 12
Continue to review full report at Codecov.
|
michellethomas
approved these changes
Aug 14, 2018
michellethomas
pushed a commit
that referenced
this pull request
Dec 1, 2021
…cy (#86) * feat: add new subgenerators for legacy package and demo * feat: make the default generator provide choices to choose subgenerators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR cherrypick following prs from Superset master:
Dashboard related:
[Dashobard]Fix bad merge (apache#5624)
set default layout for new added charts (apache#5425)
Remove dashboard transition related config (apache#5505)
This feature improves line type for timeshift chart:
Improve time shift (apache#5140)
@michellethomas @john-bodley @timifasubaa