make sure there is a val to be set for existing filters (apache#5257)

airbnb · Jul 25, 2018 · c49434e · c49434e
1 parent bd2d358
commit c49434e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/superset/utils.py b/superset/utils.py
@@ -737,7 +737,7 @@ def get_filter_key(f):
             return f['col'] + '__' + f['op']
         existing_filters = {}
         for existing in form_data['filters']:
-            if existing['col'] is not None:
+            if existing['col'] is not None and existing['val'] is not None:
                 existing_filters[get_filter_key(existing)] = existing['val']
         for filtr in form_data['extra_filters']:
             # Pull out time filters/options and merge into form data