[3.6] Use Iterable hint instead of Sequence (#4125) (#4133)

Given that the `FrozenList` type hint is `Union[List[_T], Iterable[_T]]` the Application middleware type should not restrict to `Sequence` and support all `Iterable` types.. (cherry picked from commit 8475395) Co-authored-by: Stefan T <[email protected]>
aio-libs · Oct 3, 2019 · f8c6db2 · f8c6db2
1 parent aa221d7
commit f8c6db2
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/CHANGES/4125.feature b/CHANGES/4125.feature
@@ -0,0 +1 @@
+Use `Iterable` hint instead of `Sequence` for `Application` `middleware` parameter.
diff --git a/CONTRIBUTORS.txt b/CONTRIBUTORS.txt
@@ -216,6 +216,7 @@ Simon Kennedy
 Sin-Woo Bang
 Stanislas Plum
 Stanislav Prokop
+Stefan Tjarks
 Stepan Pletnev
 Stephen Granade
 Steven Seguin

diff --git a/aiohttp/web_app.py b/aiohttp/web_app.py
@@ -88,7 +88,7 @@ class Application(MutableMapping[str, Any]):
     def __init__(self, *,
                  logger: logging.Logger=web_logger,
                  router: Optional[UrlDispatcher]=None,
-                 middlewares: Sequence[_Middleware]=(),
+                 middlewares: Iterable[_Middleware]=(),
                  handler_args: Mapping[str, Any]=None,
                  client_max_size: int=1024**2,
                  loop: Optional[asyncio.AbstractEventLoop]=None,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Use `Iterable` hint instead of `Sequence` for `Application` `middleware` parameter.