dropped app.router.add_subapp() #1592

CHANGES.rst

@@ -7,3 +7,6 @@ CHANGES
 - Dropped: `aiohttp.protocol.HttpPrefixParser`  #1590
 
 - Dropped: Servers response's `.started`, `.start()` and `.can_start()` method  #1591
+
+- Dropped: Adding `sub app` via `app.router.add_subapp()` is deprecated
+  use `app.add_subapp()` instead #1592

aiohttp/web.py

@@ -42,9 +42,6 @@ def __init__(self, *, logger=web_logger, loop=None,
             router = web_urldispatcher.UrlDispatcher()
         assert isinstance(router, AbstractRouter), router
 
-        # backward compatibility until full deprecation
-        router.add_subapp = _wrap_add_subbapp(self)
-
         if debug is ...:
             debug = loop.get_debug()
 
@@ -285,16 +282,6 @@ def __repr__(self):
         return "<Application 0x{:x}>".format(id(self))
 
 
-def _wrap_add_subbapp(app):
-    # backward compatibility
-
-    def add_subapp(prefix, subapp):
-        warnings.warn("Use app.add_subapp() instead", DeprecationWarning)
-        return app.add_subapp(prefix, subapp)
-
-    return add_subapp
-
-
 def run_app(app, *, host='0.0.0.0', port=None,
             shutdown_timeout=60.0, ssl_context=None,
             print=print, backlog=128, access_log_format=None,

tests/test_urldispatch.py

@@ -913,12 +913,6 @@ def test_subapp_get_info(app, loop):
     assert resource.get_info() == {'prefix': '/pre', 'app': subapp}
 
 
-def test_subapp_backward_compatible(router, loop):
-    subapp = web.Application(loop=loop)
-    resource = router.add_subapp('/pre', subapp)
-    assert resource.get_info() == {'prefix': '/pre', 'app': subapp}
-
-
 def test_subapp_url(app, loop):
     subapp = web.Application(loop=loop)
     resource = app.add_subapp('/pre', subapp)