feat: generate more accurate agent object #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
|
looking good, can we pass algo-type as part of the digest, we can use fixed algo for now for simplification. something like |
|
can we also strip the |
|
notes above may not be relevant for the current PR, but we do need to address these |
I'm addressing the extension part in the next PR a bit, but some additional changes will still need to be implemented serverside for perfect extension example generation. |
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
akijakya
force-pushed
the
generate-agent-object
branch
from
93384d5 to
b5072a6
Compare
* fix: add image back to dictionary * feat: add prefix to generated hashes Signed-off-by: András Jáky <[email protected]> * feat: add observability formats class as extension Signed-off-by: András Jáky <[email protected]> * feat: generate array of string enums Signed-off-by: András Jáky <[email protected]> * feat: only update class/category uid if is present Signed-off-by: András Jáky <[email protected]> * feat: modify base_feature So the extension schema has name and version but does not have unnecessary class and category names and uids. Signed-off-by: András Jáky <[email protected]> * feat: agent extension to point to feature classes Signed-off-by: András Jáky <[email protected]> --------- Signed-off-by: András Jáky <[email protected]>
lgecse
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified digest and url attributes to generate better Agent jsons.