-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement some libzypp error callbacks #1932
Open
imobachgs
wants to merge
6
commits into
master
Choose a base branch
from
libzypp-errors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
force-pushed
the
libzypp-errors
branch
4 times, most recently
from
January 22, 2025 12:58
70bf317
to
01b344f
Compare
imobachgs
force-pushed
the
libzypp-errors
branch
from
January 22, 2025 13:02
01b344f
to
86721b6
Compare
Pull Request Test Coverage Report for Build 12908783837Details
💛 - Coveralls |
jreidinger
reviewed
Jan 22, 2025
|
||
# DoneProvide callback | ||
# | ||
# @return [String] "I" for ignore, "R" for retry and "C" for abort (not implemented) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NP: I think it would be better to use constants like IGNORE
and RETRY
in code instead of C or I.
jreidinger
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Agama only implements a few libzypp error callbacks, so many times it does not report problems
properly.
Solution
Implement more libzypp error callbacks, reporting more types of problems.
Testing
Future