fix(web): storage reprobe #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
storage-reprobe
branch
from
715a367 to
522a071
Compare
joseivanlopez
force-pushed
the
storage-reprobe
branch
from
c5616a6 to
c0b9560
Compare
- Add #reprobe - Remove #refresh - Move useful methods from proposal file.
- DeviceSelector component is not used anymore.
joseivanlopez
force-pushed
the
storage-reprobe
branch
from
c0b9560 to
26a5dc3
Compare
ancorgs
reviewed
Jan 17, 2025
| * @fixme Make DriveEditor to work when the device is not found (e.g., after disabling | ||
| * a iSCSI device). | ||
| */ | ||
| if (device === undefined) return null; |
There was a problem hiding this comment.
Please create a Trello card for this.
There was a problem hiding this comment.
joseivanlopez
merged commit 938378d
into
agama-project:storage-config-ui
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the system is set as deprecated (e.g., after activating iSCSI devices), then the web client automatically reprobes the storage devices and recalculates the proposal. That is done by 3 different calls (fetch config, probe, and set config). This makes the process very unreliable if more than one reprobing is done at the same time. As side effect, the current storage config could be lost, getting the initial storage proposal instead.
Solution
Add a new D-Bus method for reprobing in an atomic way. The system is set as "no deprecated" at the end of the action. Now clients can simultaneously call to reprobe without any risk.