Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bedrock Boto3 Client Timeout #1431

Merged
merged 6 commits into from
Mar 27, 2025

Conversation

ronaldpereira
Copy link
Contributor

Fix bedrock boto3 read_timeout error when setting LLMConfig timeout higher than 60 seconds.

Why are these changes needed?

When calling bedrock models, botocore gives a read_timeout exception almost every time when the model call takes longer than 60 seconds. For faster models this is ok, but for newer and heavier models (e.g., claude-3.7), it isn't enough. So we already have a timeout llm_config attribute that we can set directly into the boto3 config instance.

Related issue number

No issue related.

Checks

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2025

CLA assistant check
All committers have signed the CLA.

@davorrunje davorrunje enabled auto-merge March 20, 2025 22:40
@davorrunje davorrunje self-assigned this Mar 20, 2025
auto-merge was automatically disabled March 20, 2025 23:25

Head branch was pushed to by a user without write access

@ronaldpereira ronaldpereira force-pushed the fix/bedrock-boto3-timeout branch from 23af12d to 4ca8281 Compare March 20, 2025 23:25
@ronaldpereira
Copy link
Contributor Author

@davorrunje my git user.email was wrong. I've forced push the same commits with my updated email now. The CLA action detected correctly that I've signed it as well.

Copy link
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ronaldpereira!

@marklysze marklysze added this pull request to the merge queue Mar 27, 2025
Merged via the queue into ag2ai:main with commit 738e1a1 Mar 27, 2025
12 checks passed
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
autogen/oai/bedrock.py 25.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fe622b4) and HEAD (f5115ab). Click for more details.

HEAD has 2532 uploads less than BASE
Flag BASE (fe622b4) HEAD (f5115ab)
3.10 191 0
ubuntu-latest 292 1
commsagent-discord 18 0
optional-deps 282 0
3.13 169 0
core-without-llm 28 1
macos-latest 208 0
commsagent-slack 18 0
3.9 165 0
3.11 128 1
browser-use 14 0
3.12 72 0
windows-latest 225 0
commsagent-telegram 18 0
retrievechat-qdrant 28 0
graph-rag-falkor-db 12 0
retrievechat-mongodb 20 0
jupyter-executor 18 0
retrievechat-pgvector 20 0
twilio 18 0
retrievechat 30 0
interop 26 0
interop-pydantic-ai 18 0
interop-crewai 18 0
interop-langchain 18 0
crawl4ai 26 0
websockets 18 0
docs 12 0
cerebras 29 0
teachable 8 0
agent-eval 2 0
gpt-assistant-agent 6 0
together 28 0
anthropic 32 0
long-context 6 0
retrievechat-couchbase 6 0
lmm 8 0
websurfer 30 0
gemini 30 0
mistral 28 0
llama-index-agent 6 0
swarm 28 0
groq 28 0
bedrock 30 0
cohere 29 0
ollama 29 0
core-llm 18 0
integration 24 0
openai-realtime 2 0
falkordb 4 0
gemini-realtime 2 0
captainagent 2 0
autobuild 2 0
neo4j 4 0
deepseek 2 0
openai 2 0
Files with missing lines Coverage Δ
autogen/oai/bedrock.py 23.43% <25.00%> (-20.62%) ⬇️

... and 69 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ronaldpereira ronaldpereira deleted the fix/bedrock-boto3-timeout branch April 7, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants