Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Bitbucket tags sorted in descending order #756

Conversation

idpaterson
Copy link

@idpaterson idpaterson commented Jan 10, 2019

This change ensures that the latest tag is returned on the first page of the response. It is possible with the default ascending(ish) sort for new tags to appear on the second or later results page causing the plugin to download older tags instead (#752).

For reference, sort=-name should sort correctly for semver tags, not entirely clear how to interpret this for other tag formats:

The name field is handled specially for tags in that, if specified as the sort field, it uses a natural sort order instead of the default lexicographical sort order. For example, it will return ['1.1', '1.2', '1.10'] instead of ['1.1', '1.10', '1.2'].

…g is returned on the first page of the response
@afragen
Copy link
Owner

afragen commented Jan 10, 2019

I have a separate method of adding endpoints to the specific API request but at the moment there aren’t any for Bitbucket.

@idpaterson
Copy link
Author

Oops! I'll leave you to filling out the add_endpoints method, that's a bit beyond my level of familiarity with github-updater. At least this pull request works as a quick patch if anyone else is having trouble in the meantime.

@afragen afragen closed this in e6c9415 Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants