Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bevy 0.11.0-dev compatibility #200

Closed
wants to merge 3 commits into from

Conversation

coreh
Copy link

@coreh coreh commented May 4, 2023

Hey 👋

I needed picking for a project targeting the latest current main bevy branch, (v0.11.0-dev) so I've updated this crate (and also bevy_mod_raycast) to work under it. Here are the breaking changes I had to account for:

  • Removal of base sets
  • Changes to .add_systems()
  • Y coordinate of cursor position is no longer flipped

It's likely there will be more breaking changes before the 0.11.0 release; I'll try to keep this PR up-to-date.

To Do

  • Double check all schedule assignments are indeed correct, I tried my best but there were a lot of them, I might have gotten one or two switched up by mistake. All demos (except alternate backends? see below) seem to be working correctly, though.
  • Get backend_egui working (Might need upstream update?)
  • Get backend_rapier3d working (Might need upstream update?)

Related PRs

Raycasting PR: aevyrie/bevy_mod_raycast#78

@coreh coreh changed the title Bevy 0.11 compatibility Bevy 0.11.0-dev compatibility May 4, 2023
@aevyrie
Copy link
Owner

aevyrie commented May 4, 2023

Damn, that was fast. Thank you!

@Vrixyz
Copy link
Contributor

Vrixyz commented Jun 22, 2023

for the bevy_egui backend, you can check out vladbat00/bevy_egui#188 :)

@Vrixyz
Copy link
Contributor

Vrixyz commented Jun 27, 2023

I refreshed a bit the PR there: coreh#1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also remove the Y flipping for touch events here.

@coreh
Copy link
Author

coreh commented Jul 18, 2023

Closed in favor of #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants