Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define available jenkins configuration parameters #67

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

M-Davies
Copy link

@M-Davies M-Davies commented Mar 1, 2021

Part 1 of adoptium/temurin-build#2129
Signed-off-by: Morgan Davies [email protected]

@github-actions
Copy link

github-actions bot commented Mar 1, 2021

Thank you for creating a pull request!
In order to run the pipeline tests I require an admin to post the following comment: run tests

@M-Davies M-Davies force-pushed the config_faq branch 2 times, most recently from 28fcfef to 2807874 Compare March 1, 2021 16:15
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about a full removal of the FAQ.md. It is very difficult for people to get up to speed in stuff in our repositories and a basic document of "To do this, change this file" without all the background infromation is extremely valuable (I made a similar comment in adoptium/infrastructure#1974 (review)). If you really think we have no such content left then I mighe be ok with that, but it seems unlikely ...

@M-Davies
Copy link
Author

M-Davies commented Mar 1, 2021

@sxa The FAQ is still going to available in https://github.com/AdoptOpenJDK/openjdk-build, even after #2463. I'm just removing it from here so we don't have two duplicate FAQ's floating around

@sxa
Copy link
Member

sxa commented Mar 1, 2021

available

There is stuff that would be specific to this repository - in fact a lot of the "end-user" stuff including running make-adopt-build-farm.sh vs makejdk-any-platform.sh could be in one here and expecting people to go to a repository about the pipelines for that and stuff like the "find your way around" chart and compiler prereqs seems a little odd so the information should perhaps be split between both repositories too.

@M-Davies
Copy link
Author

M-Davies commented Mar 1, 2021

available

There is stuff that would be specific to this repository - in fact a lot of the "end-user" stuff including running make-adopt-build-farm.sh vs makejdk-any-platform.sh could be in one here and expecting people to go to a repository about the pipelines for that and stuff like the "find your way around" chart and compiler prereqs seems a little odd so the information should perhaps be split between both repositories too.

In that case, would you prefer two FAQ's? One here and one in openjdk-build, each answering questions about their respective repositories?

@sxa
Copy link
Member

sxa commented Mar 1, 2021

available

There is stuff that would be specific to this repository - in fact a lot of the "end-user" stuff including running make-adopt-build-farm.sh vs makejdk-any-platform.sh could be in one here and expecting people to go to a repository about the pipelines for that and stuff like the "find your way around" chart and compiler prereqs seems a little odd so the information should perhaps be split between both repositories too.

In that case, would you prefer two FAQ's? One here and one in openjdk-build, each answering questions about their respective repositories?

I think that's the only sensible choice unless the infromation specific to this repository is made available elsewhere in here.

@karianna karianna added this to the March 2021 milestone Mar 1, 2021
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* Centralised location for groovy config param descriptions and usage
* Also modifies the FAQ.md of this repo as it's not being removed by adoptium/temurin-build#2463

Signed-off-by: Morgan Davies [email protected]
M-Davies pushed a commit to M-Davies/openjdk-build that referenced this pull request Mar 1, 2021
* Twin PR for ci-jenkins-pipelines:
adoptium/ci-jenkins-pipelines#67

Signed-off-by: Morgan Davies <[email protected]>
@M-Davies
Copy link
Author

M-Davies commented Mar 1, 2021

Twin PR for updating the FAQ of openjdk-build -> adoptium/temurin-build#2506

@M-Davies M-Davies requested a review from sxa March 1, 2021 18:43
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can tell - thanks :-)

@M-Davies M-Davies merged commit e968316 into adoptium:master Mar 1, 2021
sxa pushed a commit to sxa/ci-jenkins-pipelines that referenced this pull request Mar 2, 2021
* Centralised location for groovy config param descriptions and usage
* Also modifies the FAQ.md of this repo as it's not being removed by adoptium/temurin-build#2463

Signed-off-by: Morgan Davies [email protected]
M-Davies pushed a commit to M-Davies/openjdk-build that referenced this pull request Mar 3, 2021
* Twin PR for ci-jenkins-pipelines:
adoptium/ci-jenkins-pipelines#67

Signed-off-by: Morgan Davies <[email protected]>
M-Davies pushed a commit to adoptium/temurin-build that referenced this pull request Mar 3, 2021
* Twin PR for ci-jenkins-pipelines:
adoptium/ci-jenkins-pipelines#67

Signed-off-by: Morgan Davies <[email protected]>
gdams pushed a commit that referenced this pull request Mar 4, 2021
* add support for building bisheng JDK11 on riscv

Signed-off-by: Stewart X Addison <[email protected]>

* Define available jenkins configuration parameters (#67)

* Centralised location for groovy config param descriptions and usage
* Also modifies the FAQ.md of this repo as it's not being removed by adoptium/temurin-build#2463

Signed-off-by: Morgan Davies [email protected]

* Whitespace fixes to line things up and make it look pretty

Signed-off-by: Stewart X Addison <[email protected]>

Co-authored-by: Morgan Davies <[email protected]>
vsebe pushed a commit to vsebe/ci-jenkins-pipelines that referenced this pull request May 12, 2022
Configure Semeru 19 pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants