-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define available jenkins configuration parameters #67
Conversation
Thank you for creating a pull request! |
28fcfef
to
2807874
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about a full removal of the FAQ.md. It is very difficult for people to get up to speed in stuff in our repositories and a basic document of "To do this, change this file" without all the background infromation is extremely valuable (I made a similar comment in adoptium/infrastructure#1974 (review)). If you really think we have no such content left then I mighe be ok with that, but it seems unlikely ...
@sxa The FAQ is still going to available in https://github.com/AdoptOpenJDK/openjdk-build, even after #2463. I'm just removing it from here so we don't have two duplicate FAQ's floating around |
There is stuff that would be specific to this repository - in fact a lot of the "end-user" stuff including running |
In that case, would you prefer two FAQ's? One here and one in openjdk-build, each answering questions about their respective repositories? |
I think that's the only sensible choice unless the infromation specific to this repository is made available elsewhere in here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Centralised location for groovy config param descriptions and usage * Also modifies the FAQ.md of this repo as it's not being removed by adoptium/temurin-build#2463 Signed-off-by: Morgan Davies [email protected]
* Twin PR for ci-jenkins-pipelines: adoptium/ci-jenkins-pipelines#67 Signed-off-by: Morgan Davies <[email protected]>
Twin PR for updating the FAQ of openjdk-build -> adoptium/temurin-build#2506 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as far as I can tell - thanks :-)
* Centralised location for groovy config param descriptions and usage * Also modifies the FAQ.md of this repo as it's not being removed by adoptium/temurin-build#2463 Signed-off-by: Morgan Davies [email protected]
* Twin PR for ci-jenkins-pipelines: adoptium/ci-jenkins-pipelines#67 Signed-off-by: Morgan Davies <[email protected]>
* Twin PR for ci-jenkins-pipelines: adoptium/ci-jenkins-pipelines#67 Signed-off-by: Morgan Davies <[email protected]>
* add support for building bisheng JDK11 on riscv Signed-off-by: Stewart X Addison <[email protected]> * Define available jenkins configuration parameters (#67) * Centralised location for groovy config param descriptions and usage * Also modifies the FAQ.md of this repo as it's not being removed by adoptium/temurin-build#2463 Signed-off-by: Morgan Davies [email protected] * Whitespace fixes to line things up and make it look pretty Signed-off-by: Stewart X Addison <[email protected]> Co-authored-by: Morgan Davies <[email protected]>
Configure Semeru 19 pipelines
Part 1 of adoptium/temurin-build#2129
Signed-off-by: Morgan Davies [email protected]