Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay): remove flex display for dialog #4902

Merged
merged 8 commits into from
Nov 11, 2024
Merged

fix(overlay): remove flex display for dialog #4902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1e82beb
fix(overlay): use overlaynopopover for webkit
Nov 5, 2024
c0833d8
fix: css
Nov 5, 2024
ce071a7
fix: css
Nov 5, 2024
b2aaf98
fix: remove flex
Nov 6, 2024
c529caf
fix: remove unnecessary awaits
Nov 6, 2024
40ef5d5
Merge branch 'main' into abaicu/safari-tooltip
Rajdeepc Nov 7, 2024
812c84a
Merge branch 'main' into abaicu/safari-tooltip
rubencarvalho Nov 7, 2024
94fe200
Merge branch 'main' into abaicu/safari-tooltip
rubencarvalho Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions packages/overlay/src/OverlayPopover.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,7 @@ export function OverlayPopover<T extends Constructor<AbstractOverlay>>(
});
}

private async shouldShowPopover(
targetOpenState: boolean
): Promise<void> {
private shouldShowPopover(targetOpenState: boolean): void {
let popoverOpen = false;
try {
popoverOpen = this.dialogEl.matches(':popover-open');
Expand All @@ -118,7 +116,7 @@ export function OverlayPopover<T extends Constructor<AbstractOverlay>>(
this.isConnected
) {
this.dialogEl.showPopover();
await this.managePosition();
this.managePosition();
}
}

Expand All @@ -129,7 +127,7 @@ export function OverlayPopover<T extends Constructor<AbstractOverlay>>(
if (!supportsOverlayAuto) {
await this.shouldHidePopover(targetOpenState);
}
await this.shouldShowPopover(targetOpenState);
this.shouldShowPopover(targetOpenState);
await nextFrame();
}

Expand Down
4 changes: 2 additions & 2 deletions packages/overlay/src/overlay.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ governing permissions and limitations under the License.
border: 0;
background: none;
padding: 0;
display: flex;
position: fixed;
overflow: visible;
opacity: 1 !important;
Expand Down Expand Up @@ -180,7 +179,8 @@ slot[name='longpress-describedby-descriptor'] {
@supports (overlay: auto) {
.dialog {
display: none;
transition: all
transition:
all
var(
--mod-overlay-animation-duration,
var(--spectrum-animation-duration-100, 0.13s)
Expand Down
Loading