Skip to content

Commit

Permalink
fix(slider): update variant attribute correctly (#4714)
Browse files Browse the repository at this point in the history
  • Loading branch information
TarunAdobe authored and nikkimk committed Sep 12, 2024
1 parent ae85d03 commit 05b2340
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/slider/src/Slider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,11 @@ export class Slider extends SizedMixin(ObserveSlotText(SliderHandle, ''), {
return;
}
if (variants.includes(variant) && this.fillStart === undefined) {
this.setAttribute('variant', variant);
this._variant = variant;
this.setAttribute('variant', variant);
} else {
this.removeAttribute('variant');
this._variant = '';
this.removeAttribute('variant');
}
this.requestUpdate('variant', oldVariant);
}
Expand Down

0 comments on commit 05b2340

Please sign in to comment.