forked from argoproj/argo-rollouts
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support namespaced Datadog credentials #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a CI file with the minimum.
Published E2E Test Results 4 files 4 suites 3h 25m 34s ⏱️ For more details on these failures, see this check. Results for commit 4da856b. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 174 tests 2 174 ✅ 2m 54s ⏱️ Results for commit 4da856b. ♻️ This comment has been updated with latest results. |
tjamet
reviewed
Aug 12, 2024
Co-authored-by: Thibault Jamet <[email protected]>
…outs into datadog-multi-account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull adds ability to use namespaced credentials for Datadog metrics provider.
Background
Our use case involves an Argo Rollout that operates across multiple namespaces, each managed by tenants with distinct Datadog accounts. As a result, multiple credentials are needed to integrate seamlessly with Datadog.
Implementation
This setup will allow users to use different credentials than the one setup as default, which is a secret named "datadog" deployed in the same namespaces as the rollouts controller [refer to doc].
This way the users can manage their datadog credentials with the name they want and in their own namespace.
The process suggested within this PR for retrieving Datadog credentials is as follows:
1. If a
secretRef
is defined in theAnalysisTemplate
: Argo Rollouts will search for the secret with the specified name in the namespace where the template resides.2. If the secret is not found in the specified namespace: Argo Rollouts will then check the environment variables.
3. If the credentials are not found in environment variables: Argo Rollouts will look for a secret named "Datadog" in the namespace where Argo Rollouts itself is deployed.
Notes:
Based on the code, to have more than one set of credentials is not possible. I also created a question for this which remains unanswered
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.