Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Update documentation for quizBankId (fix #209) #210

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Chore: Update documentation for quizBankId (fix #209) #210

merged 1 commit into from
Jan 30, 2025

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Jan 17, 2025 •
edited
Loading

Fix #209

Chore

  • Clarify in documentation that _quizBankId should be a number not a string.

@swashbuck swashbuck self-assigned this Jan 17, 2025
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@cahirodoherty-learningpool
Copy link
Contributor

cahirodoherty-learningpool commented Jan 22, 2025 •
edited
Loading

Hi Brad, I think a Chore: prefix would be sufficient here as we don't need to trigger a release tag for the change, just get it onto the master branch
i.e. Chore: Update documentation for quizBankId (fix #209)

@swashbuck swashbuck changed the title Fix: Update documentation for quizBankId (fix #209) Chore: Update documentation for quizBankId (fix #209) Jan 22, 2025
@joe-allen-89 joe-allen-89 merged commit 359e9c5 into master Jan 30, 2025
1 check passed
@joe-allen-89 joe-allen-89 deleted the issue/209 branch January 30, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@swashbuck swashbuck

Labels
documentation
Projects
adapt_framework: The TODO Board
Status: Recently Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: quizBankID should be a number
4 participants
@swashbuck @cahirodoherty-learningpool @oliverfoster @joe-allen-89