Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: trigger assessment:restored appropriately (fixes #186) #187

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix: trigger assessment:restored appropriately (fixes #186) #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions js/assessment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,15 @@ class Assessment extends Backbone.Controller {
'router:plugin': this._handleRoute,
'app:dataReady': this._onDataReady
});

this.triggerAssessmentsRestored();
}

async triggerAssessmentsRestored() {
await data.whenReady();

// all assessments have now registered and we can determine state
Adapt.trigger('assessment:restored', this.getState());
}

_onAssessmentsComplete(state) {
Expand Down Expand Up @@ -287,12 +296,6 @@ class Assessment extends Backbone.Controller {
this._setPageProgress();

this._setupQuestionNumbering();

if (this._restoredCount === this._assessments.length) {
// Since all assessments have been stored, broadcast an
// event which has the collated state.
Adapt.trigger('assessment:restored', this.getState());
}
}

get(id) {
Expand Down