resolves #146 remove PDB files instead of truncating them

[slonopotamus]

This commit fixes 'error CS0045: Unexpected error creating debug information file' that occurs when UE4 builds Engine/Intermediate/Build/BuildRules/UE4Rules.dll on Windows

---

Tested using "way to reproduce" from #146 against UE-4.26.1 on Windows 2019 LTSC and 20H2:

1. ue4-docker build 4.26.1 --no-engine --exclude ddc --exclude templates --exclude debug
2. ue4-docker test 4.26.1

---

Note that I failed to find any info on why truncation was needed in the first place. Truncation was initially implemented in f3f5fbb but neither commit message nor code comments explain what scenario fails in case PDB files are completely removed. I also failed to find relevant issues on GitHub.

[alexgeek]

Trying this as I have the same issues with 4.25, 4.26.

I got this this though?

 ---> Running in 5d52de85af73
Chocolatey v0.10.15
Installing the following packages:
windows-sdk-10-version-1809-windbg
By installing you accept licenses for the packages.
windows-sdk-10-version-1809-windbg not installed. An error occurred during installation:
 The remote server returned an error: (503) Server Unavailable. Service Unavailable
windows-sdk-10-version-1809-windbg package files install completed. Performing other installation steps.
The install of windows-sdk-10-version-1809-windbg was NOT successful.
windows-sdk-10-version-1809-windbg not installed. An error occurred during installation:
 The remote server returned an error: (503) Server Unavailable. Service Unavailable

Chocolatey installed 0/1 packages. 1 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - windows-sdk-10-version-1809-windbg (exited 1) - windows-sdk-10-version-1809-windbg not installed. An error occurred during installation:
 The remote server returned an error: (503) Server Unavailable. Service Unavailable
The command 'cmd /S /C choco install -y windows-sdk-10-version-1809-windbg && echo. && echo.RUN directive complete. Docker will now commit the filesystem layer to disk. && echo.Note that for large filesystem layers this can take quite some time. && echo.Performing filesystem layer commit... && echo.' returned a non-zero code: 1
[ue4-docker build] Error: failed to build image "adamrehn/ue4-build-prerequisites:20H2".

Edit: Nvm, Chocolately is down.

[slonopotamus]

Your error has nothing to do with this PR. For some reason, you get 503 when trying to install windows-sdk-10-version-1809-windbg via Chocolatey.

[alexgeek]

Your error has nothing to do with this PR. For some reason, you get 503 when trying to install windows-sdk-10-version-1809-windbg via Chocolatey.

Yeah I edited the comment. Chocolately has scheduled maintenance.

[alexgeek]

Choco is backup but I'm having to add --ignore-checksums to line 3 of install-prerequesites.bat as vcredist2010 is failing.

[alexgeek]

Hey, was able to build with 4.26.1 but 4.25.4 didn't finish:

re-exec error: exit status 1: output: write \\?\C:\ProgramData\Docker\tmp\hcs718544531\Files\UnrealEngine\Engine\Intermediate\Build\Win64\UE4Editor\Development\UnrealEd\SharedPCH.UnrealEd.ShadowErrors.h.pch: There is not enough space on the disk.
[ue4-docker build] Error: failed to build image "adamrehn/ue4-minimal:4.25.4-20H2"

[slonopotamus]

Maybe you forgot to pass --exclude debug? That error is #99.

[alexgeek]

Maybe you forgot to pass --exclude debug? That error is #99.

Unfortunately not, it was:

ue4-docker build 4.25.4 --no-engine --exclude ddc --exclude templates --exclude debug

[slonopotamus]

@alexgeek I first suggest you moving this discussion to #99 (because you're clearly hitting it and it's not related to current PR). Second, please make sure that you use latest Docker release. You may also want to run ue4-docker diagnostic all. It does check for one of the two root causes of #99 and if it fails for you, it most likely means you need to update Docker.

[alexgeek]

@alexgeek I first suggest you moving this discussion to #99 (because you're clearly hitting it and it's not related to current PR). Second, please make sure that you use latest Docker release. You may also want to run ue4-docker diagnostic all. It does check for one of the two root causes of #99 and if it fails for you, it most likely means you need to update Docker.

Sorry ignore me anyway, it was genuinely running out of space. Managed to get a build eventually and it does work. Thanks

[slonopotamus]

We agreed with @adamrehn that this needs to be tested on 4.20. It will either pass (and then we just merge this PR and later work on more fine-grained PDB pruning that matches what UE4 from Launcher does) or it will fail (and then we will know what was that "manifest errors" thing). In the latter case, this cannot be merged as-is and we need to directly go the "more fine-grained PDB pruning" approach.

[slonopotamus]

I've just finished ue4-docker test 4.20.3 against this PR and it Just Works (well, it hits adamrehn/conan-ue4cli#12 but anyway). So, I see no reasons preventing me from merging this PR.