Update php for support/4 #661
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the GitHub Actions configuration to support PHP 8.4 testing under the support/4 initiative. It introduces a new configuration block for running isolated tests on PHP 8.4 with specific settings for Drupal 10 and coverage generation in CLOVER format.
Files not reviewed (3)
- composer.json: Language not supported
- src/Domain/Composer/ComposerFacade.php: Language not supported
- src/Domain/Package/Package.php: Language not supported
| # Testing Drupal 10 in php 8.4. | ||
| - orca-job: ISOLATED_TEST_ON_CURRENT | ||
| php-version: "8.4" | ||
| orca-enable-nightwatch: "FALSE" |
There was a problem hiding this comment.
The configuration for 'orca-enable-nightwatch' is inconsistent with the earlier one (defined as a list). Consider unifying the data type across the workflow for consistency.
| orca-enable-nightwatch: "FALSE" | |
| orca-enable-nightwatch: ["FALSE"] |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
suggested changes are getting failed while testing on wip branch, so keeping it as it is
There was a problem hiding this comment.
Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- composer.json: Language not supported
- src/Domain/Composer/ComposerFacade.php: Language not supported
- src/Domain/Package/Package.php: Language not supported
| php-version: "8.4" | ||
| orca-enable-nightwatch: ["FALSE"] | ||
| # Testing coverage generation in CLOVER format. | ||
| orca-coverage-clover-enable: "TRUE" |
There was a problem hiding this comment.
The value for 'orca-coverage-clover-enable' is set as a string, while similar flags use an array format (e.g., 'orca-coverage-enable' on line 66). Consider using the array format for consistency.
| orca-coverage-clover-enable: "TRUE" | |
| orca-coverage-clover-enable: ["TRUE"] |
Copilot uses AI. Check for mistakes.
No description provided.