Add use_legacy_dicom_study_importer config #9749
Merged
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximemulder
added
Language: SQL
cmadjar
requested changes
Apr 14, 2025
There was a problem hiding this comment.
@maximemulder the default schema also needs to be updated to add this config and set the default pipeline to the new python DICOM importer.
SQL/New_patches/2025-04-14_add-use-legacy-dicom-importer-config.sql
Outdated
Show resolved
Hide resolved
maximemulder
changed the title
cmadjar
requested changes
Apr 15, 2025
There was a problem hiding this comment.
Thanks for the changes!!
I think you will also need to add that to the raisinbread files. Sorry, only though about this now...
https://github.com/aces/Loris/blob/main/raisinbread/RB_files/RB_Config.sql
and
https://github.com/aces/Loris/blob/main/raisinbread/RB_files/RB_ConfigSettings.sql
github-actions
bot
added
the
RaisinBread
|
@cmadjar Oh, didn't know Rainsinbread needed its own config values, thanks for the tip ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR to LORIS-MRI#1264, the code is basically copied from the "is_qsub" parameter.