Skip to content

Dicom archive 'Download as CSV' button now works properly #9687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dicom archive 'Download as CSV' button now works properly #9687

wants to merge 1 commit into from

Conversation

nicolasbrossard
Copy link
Contributor

When accessing the dicom archive module and clicking on the 'Download as CSV' button, the downloaded file would be missing column 'Center ID'. This PR fixes the behaviour of the download button so that all columns appear in the result set.

Fixes #9663

@nicolasbrossard nicolasbrossard added Module: dicom_archive PR or issue related to dicom_archive module php Pull requests that update Php code 27.0.0 - Bugs Bugs Found in LORIS 27 testing labels Mar 7, 2025
@charliehenrib
Copy link
Contributor

Hi @nicolasbrossard,

I looked the file. The CenterID column now appears in the CSV, but the data it contains does not make sense. It reports Y or N rather than a number.
data-2025-03-14T14_34_40.256Z.csv

@charliehenrib charliehenrib added the State: Needs work PR awaiting additional work by the author to proceed label Mar 14, 2025
@CamilleBeau
Copy link
Contributor

@nicolasbrossard See Charlie's comment to be fixed & then re-reviewed

@nicolasbrossard
Copy link
Contributor Author

@charliehenrib @CamilleBeau This PR was not merged so the bug is most likely still there on the test VM. If you checked out my branch on your VM and then tested, then my fix does not work. Can you plz tell me which scenario corresponds to what you did?

@charliehenrib
Copy link
Contributor

@charliehenrib @CamilleBeau This PR was not merged so the bug is most likely still there on the test VM. If you checked out my branch on your VM and then tested, then my fix does not work. Can you plz tell me which scenario corresponds to what you did?

I tested it on the test VM which is probably why the issue was still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nicolasbrossard nicolasbrossard

Labels
27.0.0 - Bugs Bugs Found in LORIS 27 testing Module: dicom_archive PR or issue related to dicom_archive module php Pull requests that update Php code State: Needs work PR awaiting additional work by the author to proceed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[dicom_archive] Download table as CSV is missing a column
3 participants
@nicolasbrossard @charliehenrib @CamilleBeau