fix: misc

aave · Aug 8, 2024 · 879f742 · 879f742
1 parent 77b4d54
commit 879f742
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/contracts/facilitators/gsm/feeStrategy/FixedFeeStrategyFactory.sol b/src/contracts/facilitators/gsm/feeStrategy/FixedFeeStrategyFactory.sol
@@ -4,7 +4,7 @@ pragma solidity ^0.8.10;
 import {EnumerableSet} from '@openzeppelin/contracts/utils/structs/EnumerableSet.sol';
 import {VersionedInitializable} from '@aave/core-v3/contracts/protocol/libraries/aave-upgradeability/VersionedInitializable.sol';
 import {IFixedFeeStrategyFactory} from './interfaces/IFixedFeeStrategyFactory.sol';
-import {IGsmFeeStrategy} from 'src/contracts/facilitators/gsm/feeStrategy/interfaces/IGsmFeeStrategy.sol';
+import {IGsmFeeStrategy} from './interfaces/IGsmFeeStrategy.sol';
 import {FixedFeeStrategy} from './FixedFeeStrategy.sol';
 
 /**
@@ -69,7 +69,7 @@ contract FixedFeeStrategyFactory is VersionedInitializable, IFixedFeeStrategyFac
   }
 
   ///@inheritdoc IFixedFeeStrategyFactory
-  function getStrategyByFees(uint256 buyFee, uint256 sellFee) external view returns (address) {
+  function getFixedFeeStrategy(uint256 buyFee, uint256 sellFee) external view returns (address) {
     return _gsmFeeStrategiesByFees[buyFee][sellFee];
   }
 

diff --git a/src/contracts/facilitators/gsm/feeStrategy/interfaces/IFixedFeeStrategyFactory.sol b/src/contracts/facilitators/gsm/feeStrategy/interfaces/IFixedFeeStrategyFactory.sol
@@ -44,7 +44,7 @@ interface IFixedFeeStrategyFactory {
    * @param sellFee The sell fee of the fee strategy contract
    * @return The address of the fee strategy contract
    */
-  function getStrategyByFees(uint256 buyFee, uint256 sellFee) external view returns (address);
+  function getFixedFeeStrategy(uint256 buyFee, uint256 sellFee) external view returns (address);
 
   /**
    * @notice Returns the GsmFeeStrategyFactory revision number

diff --git a/src/test/TestGhoBucketSteward.t.sol b/src/test/TestGhoBucketSteward.t.sol
@@ -50,11 +50,11 @@ contract TestGhoBucketSteward is TestGhoBase {
   }
 
   function testChangeOwnership() public {
-    address NEW_OWNER = makeAddr('NEW_OWNER');
+    address newOwner = makeAddr('newOwner');
     assertEq(GHO_BUCKET_STEWARD.owner(), SHORT_EXECUTOR);
     vm.prank(SHORT_EXECUTOR);
-    GHO_BUCKET_STEWARD.transferOwnership(NEW_OWNER);
-    assertEq(GHO_BUCKET_STEWARD.owner(), NEW_OWNER);
+    GHO_BUCKET_STEWARD.transferOwnership(newOwner);
+    assertEq(GHO_BUCKET_STEWARD.owner(), newOwner);
   }
 
   function testChangeOwnershipRevert() public {
@@ -165,7 +165,7 @@ contract TestGhoBucketSteward is TestGhoBase {
     );
   }
 
-  function testUpdateFacilitatorBucketCapacityDecrement() public {
+  function testRevertUpdateFacilitatorBucketCapacityDecrement() public {
     (uint256 currentBucketCapacity, ) = GHO_TOKEN.getFacilitatorBucket(address(GHO_ATOKEN));
     vm.prank(RISK_COUNCIL);
     uint128 newBucketCapacity = uint128(currentBucketCapacity) - 1;