Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(ci): Fix incorrect docs about Docker build cache order #5190

Merged
merged 4 commits into from
Sep 27, 2022
Merged

doc(ci): Fix incorrect docs about Docker build cache order #5190

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9adbcbc
Use branch then main build caches
teor2345 Sep 19, 2022
05b6bcc
Revert cache order to try branch cache first
teor2345 Sep 19, 2022
b11aa86
Merge branch 'main' into branch-cache-first
mergify[bot] Sep 20, 2022
0bf9ce0
Merge branch 'main' into branch-cache-first
mergify[bot] Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/build-docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,11 @@ jobs:
# To improve build speeds, for each branch we push an additional image to the registry,
# to be used as the caching layer, using the `max` caching mode.
#
# We use multiple cache sources to confirm a cache hit, starting from the `main` branch cache,
# and if there's no hit, then continue with a cache scoped per branch.
# We use multiple cache sources to confirm a cache hit, starting from a per-branch cache,
# and if there's no hit, then continue with the `main` branch. Changes within a PR are usually
# small, so this provides the best performance.
#
# The last cache in the list is tried first.
cache-from: |
type=registry,ref=us-docker.pkg.dev/zealous-zebra/zebra/${{ inputs.image_name }}:main-cache
type=registry,ref=us-docker.pkg.dev/zealous-zebra/zebra/${{ inputs.image_name }}:${{ env.GITHUB_REF_SLUG_URL }}-cache
Expand Down