Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix job pod labelling #4035

Merged
merged 1 commit into from
Mar 27, 2025
Merged

fix job pod labelling #4035

merged 1 commit into from
Mar 27, 2025

Conversation

piax93
Copy link
Contributor

@piax93 piax93 commented Mar 27, 2025

  • The documentation lied to me, pods only have job-name rather than batch.kubernetes.io/job-name (maybe it's a difference across versions, I have not checked).
  • I wrongly assumed that job labels would propagate to be pod labels. I'm too naive.

@piax93 piax93 requested review from nemacysts and Qmando March 27, 2025 16:42
@piax93 piax93 requested a review from a team as a code owner March 27, 2025 16:42
@nemacysts nemacysts merged commit 8a3348f into master Mar 27, 2025
10 checks passed
@piax93 piax93 deleted the u/mpiano/SEC-19951_pod_labelling branch March 27, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemacysts nemacysts nemacysts approved these changes

@Qmando Qmando Awaiting requested review from Qmando

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piax93 @nemacysts