Document additional PaaSTA-provided env vars (+ sort list) #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was recently chatting with jrchu about default env vars and I realized that there's a couple that we didn't document.
nemacysts
requested review from
EvanKrall,
jfongatyelp,
ymilki,
EmanElsaban and
KaspariK
ymilki
previously approved these changes
Mar 26, 2025
jfongatyelp
previously approved these changes
Mar 26, 2025
docs/source/yelpsoa_configs.rst
Outdated
| * ``PAASTA_DOCKER_IMAGE``: The docker image name | ||
| * ``PAASTA_GIT_SHA``: The short git sha of the code the container has | ||
| * ``PAASTA_DEPLOY_GROUP``: The `deploy group <deploy_group.html>`_ specified | ||
| * ``PAASTA_HOST``: The hostname of the actual server the container is runnig on | ||
| * ``PAASTA_IMAGE_VERSION``: The version of the docker image |
There was a problem hiding this comment.
I think this too is not always included, only for those using --image-version w/ mark-for-deployment (likely only those using enable_automated_redeploys in yelpsoa w/ our standard pipelines)
Co-authored-by: Jen Patague <[email protected]>
nemacysts
commented
Mar 26, 2025
jfongatyelp
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was recently chatting with milki about default env vars and I realized that there's a couple that we didn't document.