First wave of fixes for remote-run #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
piax93
commented
Mar 26, 2025
piax93
commented
- Describe 403 code for remote-run apis
- Since OPA can deny remote-run requests, it'd be nice to have the right code returned from the API server rather than 500 cause the code is not in the spec (this was actually raise by @Qmando in remote-run api implementation #4022 but I turned the suggestion down, mistakenly, sorry)
- Add more output to remote-run cli
- ... because it's way too silent now, and pod don't come online instantaneusly
- Fix wrong kwarg in paasta_cleanup_remote_run_resources
- This is just linters failing me (and too much mocking in unit tests)
- Drop unneeded pod options for remote-run jobs
- We do not want this to become a way for people to deploy services in prod, so in general these pods should not have routable IPs (it'll be a different story for toolbox containers as those will run sshd).
- In my recent testing the job pod was failing to becomes ready due to hacheck. I think that may be due to some zookeeper locking which interfered with the existing replicas of the service, but at any rate, we don't want that, or any other sidecar, as this is effectively meant to be "local-run, but in a pod"
nemacysts
approved these changes
Mar 26, 2025
Comment on lines
+2228
to
+2231
| has_routable_ip = ( | ||
| "false" | ||
| if force_no_routable_ip | ||
| else self.has_routable_ip(service_namespace_config, system_paasta_config) |
There was a problem hiding this comment.
one day we'll update things so that the default is no routable ip #dream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.