new remote-run cli #4025
Merged
new remote-run cli #4025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piax93
force-pushed
the
u/mpiano/SEC-19862_client
branch
from
c31b8f6 to
205f2b7
Compare
nemacysts
reviewed
Mar 19, 2025
Comment on lines
+86
to
+91
| exec_command = KUBECTL_CMD_TEMPLATE.format( | ||
| cluster=args.cluster, | ||
| namespace=poll_response.namespace, | ||
| pod=poll_response.pod_name, | ||
| token=token_response.token, | ||
| ) |
There was a problem hiding this comment.
it'd be nice to use the kubernetes clientlib for this - but it looks like that'd result in a lot more code (and it's probably not worth the effort just to not have to rely on our kubectl wrappers)
There was a problem hiding this comment.
We tried, but it's a mess. You effectively have to build your own REPL to do input / output with the python client, and that's really not worth the effort when you can just use kubectl to do the job.
nemacysts
approved these changes
Mar 21, 2025
nemacysts
approved these changes
Mar 24, 2025
piax93
added a commit
that referenced
this pull request
Mar 25, 2025
nemacysts
pushed a commit
that referenced
this pull request
Mar 25, 2025
This was meant to be included in the last release but I (luisp) don't know how to read and merged things in the "wrong" order. This correctly merges in the following PRs: * cleanup for remote-run resources (#4024) Clean up logic for the (meant to be) ephemeral resources which are created in remote-run invocations (#4022). * new remote-run cli (#4025) Last portion of #3986, with the updated logic to reflect the updated API conventions introduced in #4022.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last portion of #3986, with the updated logic to reflect the updated API conventions introduced in #4022.